added support for guid type #122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was marked as stale since it has not been active for a long time |
sungam3r
reviewed
Dec 8, 2024
sungam3r
reviewed
Dec 8, 2024
sungam3r
reviewed
Dec 8, 2024
sungam3r
reviewed
Dec 8, 2024
sungam3r
reviewed
Dec 8, 2024
sungam3r
reviewed
Dec 8, 2024
Member
|
Thanks. I doubt about this change. LogMasked was intentionally applied only for string properties to not change any existing types. You changed guid scalar to string scalar. I suggest to made such feature opt-in to not break any existing code. |
This was referenced Dec 10, 2024
Closed
Member
|
Thanks, @mickeyperlstein . Was replaced by #126. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 237 238 +1
Branches 35 35
=========================================
+ Hits 237 238 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you dont support guid, now you do