Conversation
sergiou87
approved these changes
May 21, 2024
Member
sergiou87
left a comment
There was a problem hiding this comment.
Only one question… other than that looks good!
| # messed up with macOS SDK 11 stuff. | ||
| sudo rm -rf /Library/Developer/CommandLineTools | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v3 |
Member
There was a problem hiding this comment.
Is there any reason for not using v4 here too?
Suggested change
| - uses: actions/checkout@v3 | |
| - uses: actions/checkout@v4 |
Member
Author
There was a problem hiding this comment.
Yeah, v4 used node 20 which in turn required glibc 2.28 which we don't have on Linux thanks to our use of the 18.04 docker container. We'll have to take that fight another day but I'm afraid that day might come sooner than we'd like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git for Windows ships a whole environment including its own /etc/gitconfig which we can (and do) manipulate during build in order to insert our "sane defaults" into it. On macOS and Linux that's not the case so in this PR we're creating our own system level config that dugite can then instruct Git to use.