Lighter scrollbars in dark theme #9416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scrollbars on the dark theme are very hard to see. Changing from black to a theme-congruent gray.
Contributor
|
Does this at all impact light theme? Make sure they’re still visible there. Other than that this looks great! |
Contributor
Author
No impact to the light theme. This is merely a color change in the |
Contributor
|
Thanks for the contribution @jfgordon2! The code changes look good, @ampinsk what do you think of the design? |
tierninho
approved these changes
Apr 1, 2020
Contributor
tierninho
left a comment
There was a problem hiding this comment.
Confirming the changes look good in both Mac/Windows. 👍 Much easier to see!
Here is a side-by-side in Mac. (Windows side-by-side is too hard as all background applications hide the scroll bar.)
rafeca
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9114
Description
The scrollbars on the dark theme are very hard to see. Changing from black to light gray.
Screenshots
Release notes
Notes: no-notes