@say25 Thanks for adding this shortcut -works as me 👍

One clarification, did you mean to use "Delete-right" as it means the use of the function key is also required (at least for Mac).

Reference:

We do use the same delete key for removing a repository, but perhaps we meant to use the delete-left key? Can @desktop/engineering confirm?

@tierninho I was mostly going for consistency. At the same time, CMD+Shift+Left Delete in Finder is empty trash maybe that makes more sense?

Can @desktop/engineering confirm?

I'm honestly not fussed about what shortcut ends up being chosen here, but I'd like the reviewer(s) involved with this to test this on macOS and Windows and verify that:

• the shortcut makes sense to the user
• the shortcut does fire when the keyboard shortcut is pressed

Linux testing too would be desirable, but I suspect it'll overlap with how Windows handles this so it's not required.

My only worry was that the average user has no idea what left- and right-delete are.

Suggestion is we change both Remove Repository and Discard all to left-delete for simplicity. I assume this only affects Mac. @say25 ok to update your PR?

I was mostly going for consistency. At the same time, CMD+Shift+Left Delete in Finder is empty trash maybe that makes more sense?

👍

I don't mind making the tweak. If we are to change the shortcuts, should the shift modifier go with Remove Repository or Discard All?

Thanks for helping.

should the shift modifier go with Remove Repository or Discard All?

"Discard all Changes" (Cmd/Ctrl+Shift+Delete)
"Remove Repos" (Cmd/Ctrl+Delete)

While going through this PR I thought the same thing as @tierninho.

My only worry was that the average user has no idea what left- and right-delete are.

@say25 tested this out on macOS and Windows and I'm happy with standardizing this on CmdOrCtrl(+Shift)+Backspace given the previous confusion discussed.

I'll let this sit a couple of days and see if @desktop/engineering or @desktop/quality-assurance have any additional feedback or suggestions.