Fix broken build on development#7165
Merged
iAmWillShepherd merged 2 commits intodevelopmentfrom Mar 26, 2019
Merged
Conversation
This reverts commit c2e7276.
shiftkey
reviewed
Mar 26, 2019
shiftkey
approved these changes
Mar 26, 2019
iAmWillShepherd
approved these changes
Mar 26, 2019
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c2e7276.
Overview
#7018 was an old PR that recently got merged; in it there was a commit that removed a method that was unused at the time but that was in use on development.
We should discuss turning on branch protection to require being up to date with development before merging to avoid these kinds of issues.
Release notes
Notes: no-notes