some cleanup extracted from the rebase flow changes#7129
Merged
shiftkey merged 9 commits intodevelopmentfrom Mar 25, 2019
Merged
some cleanup extracted from the rebase flow changes#7129shiftkey merged 9 commits intodevelopmentfrom
shiftkey merged 9 commits intodevelopmentfrom
Conversation
shiftkey
commented
Mar 20, 2019
3ff1aeb to
4e750e8
Compare
shiftkey
commented
Mar 20, 2019
shiftkey
commented
Mar 20, 2019
12 tasks
e33cfc1 to
a1beb21
Compare
…rebase state before continuing
…rning just in case
a1beb21 to
1f00d9c
Compare
outofambit
reviewed
Mar 25, 2019
Contributor
outofambit
left a comment
There was a problem hiding this comment.
your inline comments were super helpful thank you! left some thoughts all over the place :) but nothing major
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a pre-requisite for the work in #7117, which can land in advance of that review.
Description
I'm going to annotate the PR with context about these changes, but the commits are atomic enough that hopefully the rest makes sense.
Release notes
Notes: no-notes