Skip to content

improve language clarity in manual merge conflict resolution UI#6821

Merged
outofambit merged 2 commits intodevelopmentfrom
manual-resolutions-ui-language
Feb 11, 2019
Merged

improve language clarity in manual merge conflict resolution UI#6821
outofambit merged 2 commits intodevelopmentfrom
manual-resolutions-ui-language

Conversation

@outofambit
Copy link
Contributor

Overview

Closes #6782

screen shot 2019-02-11 at 7 06 30 am

screen shot 2019-02-11 at 7 06 40 am

Description

  • shout out to @shiftkey for prototyping the first version of this code. i stole liberally.

@outofambit outofambit added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 11, 2019
@outofambit outofambit added this to the 1.6.2 milestone Feb 11, 2019
/** Returns a human-readable description for an available manual resolution method
* intended for use with manually resolved merge conficts
*/
export function getLabelForManualResolutionOption(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this be more appropriately located in the component that uses it?

@outofambit outofambit added the time-sensitive Pull Requests where reviews need to happen in a timely manner label Feb 11, 2019
@outofambit
Copy link
Contributor Author

marking this time-sensitive as this needs to go out in the final beta for 1.6.2 tomorrow. @iAmWillShepherd would you mind giving this a quick review?

@outofambit outofambit merged commit 4069a51 into development Feb 11, 2019
@outofambit outofambit deleted the manual-resolutions-ui-language branch February 11, 2019 20:47
@tierninho
Copy link
Contributor

Tested and LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Pull Requests that are ready to be reviewed by the maintainers time-sensitive Pull Requests where reviews need to happen in a timely manner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants