Merged
Conversation
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
a94f799 to
f168a8d
Compare
Contributor
|
Added |
shiftkey
suggested changes
Feb 7, 2019
Member
shiftkey
left a comment
There was a problem hiding this comment.
LGTM, just one bit of tidy up
Co-Authored-By: billygriffin <5091167+billygriffin@users.noreply.github.com>
shiftkey
previously approved these changes
Feb 7, 2019
shiftkey
approved these changes
Feb 7, 2019
Member
|
Waving this PR through because I know it's unrelated to whatever #6793 is doing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6772
Adds new metric to capture the number of times a user is taken to the create PR page on GitHub.com from Desktop.
We initially attempted to differentiate between the different pathways to get to this action, but because @niik's implementation of the suggested next step "Create PR" action looks to be to just hijack the menu item action, the easiest path forward here was just to have one that encompasses the three different ways to trigger it (suggested next step, keyboard shortcut, branch menu item).
metrics.mddoc - a94f799