refactor config tests to control HOME environment variable#5455
Merged
outofambit merged 5 commits intomasterfrom Aug 27, 2018
Merged
refactor config tests to control HOME environment variable#5455outofambit merged 5 commits intomasterfrom
outofambit merged 5 commits intomasterfrom
Conversation
outofambit
approved these changes
Aug 24, 2018
Contributor
outofambit
left a comment
There was a problem hiding this comment.
Looks great! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Jest PR #5427 identified some tests that touch the global config, and this is suboptimal for a couple of reasons:
This PR refactors the
config.tsto support controlling theHOMEenvironment variable, which Git should be using to read the global config. This also updates theconfig-tests.tsthat touch the global config to now use a temporary directory.