Beta release of RBB lite and multi-select lists#4545
Merged
Conversation
Contributor
|
Looks like lines 7 and 8 are the same; I’m not in front of my computer right now but I can push and update if you’re clocked out for the week |
Member
Author
|
Cheers, that’d be great. I’m not too concerned since I don’t believe
there’s a way to view the beta release notes anyway
…On Fri, 27 Apr 2018 at 17:33, Neha Batra ***@***.***> wrote:
Looks like lines 7 and 8 are the same; I’m not in front of my computer
right now but I can push and update if you’re clocked out for the week
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4545 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAmszzrXZDooQU8w_9DwwZZmwuTGZy0Yks5tszpagaJpZM4Tqduu>
.
|
nerdneha
approved these changes
Apr 27, 2018
Member
Yep, this is being tracked in #3385 |
shiftkey
approved these changes
May 2, 2018
Member
shiftkey
left a comment
There was a problem hiding this comment.
This appears to have been on the beta channel for a few days now - not sure if this is waiting on anything else...
Contributor
|
I think we didn't merge it just in case we wanted to rollback easily and just release master to beta. Things seems to be good now though, happy to merge |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussing with @nerdneha earlier today we decided that shipping RBB lite and multi-select to beta was the easiest way to get mileage on the changes as well as deliver updates to QA.
There was some concerns earlier about potential stability issues but our (my) take on this is that we'll accept some risk on the beta channel, that's what it's there for. Our need for mileage is high enough that it's important for us to get this to the beta channel as soon as possible.