Skip to content

Conversation

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Oct 9, 2017

Replaces #2300

This is the first pass at adding support for generating RPM, DEB and AppImage builds of Desktop.

This doesn't include official support, just the groundwork.

This uses the same npm run package commands that we can use on macOS and Windows.

If someone wants to contribute additional formats, please follow the conventions in script/package.

  • fix appveyor issue with linux-only package
  • cleanup after_success hooks as we shouldn't package for every build

@shiftkey
Copy link
Member Author

@shiftkey shiftkey added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 10, 2017
@joshaber joshaber self-assigned this Oct 10, 2017
Copy link
Contributor

@joshaber joshaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, well alright then ✨

@joshaber joshaber merged commit 5a638b7 into master Oct 10, 2017
@joshaber joshaber deleted the add-package-support-for-linux branch October 10, 2017 19:11
@probonopd
Copy link

@shiftkey @joshaber now that this has been merged, is there anything preventing this project from providing pre-compiled RPM, DEB and AppImage builds of Desktop on GitHub Releases?

@shiftkey
Copy link
Member Author

shiftkey commented Nov 8, 2017

@probonopd we don't use GitHub Releases for shipping updates, so we'd have to teach our infrastructure how to manage these. But that's a long-term thing.

I have some ideas about moving this forward, but I need to chat with @desktop/core first.

@wyqydsyq
Copy link

wyqydsyq commented Nov 8, 2017

@shiftkey If you guys are intending to ship native packages (.rpms and .debs) as opposed to something typically distributed as a direct download like Flatpak or AppImage, I'd strongly recommend using OBS for building and shipping:
https://build.opensuse.org/

Supports building and distributing for all major desktop distros (Ubuntu, Debian, Fedora, OpenSUSE), a lot of Linux users are already familiar with installing software from there. It can function as a repository for each distro's package manager, so you don't have to worry about manually distributing new updates for each distro's registry, just register github-desktop (or whatever package name you're going with) in each distro's official registry as pointing to that distro's build on OBS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants