open Preferences/Options to a given tab #2413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshaber
suggested changes
Aug 8, 2017
Contributor
joshaber
left a comment
There was a problem hiding this comment.
Seems legit, just one comment bikeshedding the name 👍
app/src/lib/app-state.ts
Outdated
| files: ReadonlyArray<WorkingDirectoryFileChange> | ||
| } | ||
| | { type: PopupType.Preferences } | ||
| | { type: PopupType.Preferences; initialFocusTab?: PreferencesTab } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
Author
|
🍎 |
22 tasks
Contributor
|
✨ |
joshaber
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this off from #2407 where I have this use case:
showPopupto change dialogsWith this change, I can put the user on the Advanced tab (where the setting lives) rather than leave them disoriented and not sure where to go. The default behaviour (focus on Accounts) will remain if this argument hasn't been provided.