Migrate Windows code signing from client secret to OIDC#21786
Merged
Conversation
Replace AZURE_CLIENT_SECRET-based auth with OIDC federated identity credentials via azure/login@v2. This addresses the SFI requirement (vuln-mgmt#183285) to eliminate client secrets from spn-desktop-codesign. - Add id-token: write permission to build job - Add azure/login OIDC step before packaging (Windows only) - Remove AZURE_CODE_SIGNING_CLIENT_SECRET from secrets and env vars Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
e915fbe to
47bfd5c
Compare
2 tasks
niik
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
AZURE_CLIENT_SECRET-based authentication for Windows code signing with OIDC federated identity credentials viaazure/login@v2.Changes
id-token: writepermission to thebuildjob (required for OIDC token requests)azure/login@v2step before packaging (Windows + sign only) to establish OIDC sessionAZURE_CODE_SIGNING_CLIENT_SECRETfrom workflow secrets declaration and env varsCompanion PR