Ignore Tab in terminal and keep textarea enabled#21728
Merged
niik merged 1 commit intodevelopmentfrom Mar 4, 2026
Merged
Conversation
Add a custom key event handler to the terminal to return false for 'Tab' key events so the terminal doesn't intercept app tab navigation (terminal is read-only and doesn't accept Tab). Also remove the code that disabled the terminal textarea so focus/tab navigation and accessibility are preserved.
sergiou87
approved these changes
Mar 4, 2026
|
@niik thanks for adding this! I was about to start on a branch to enable copy-paste from the pre-commit modal, but you got there first :) 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21696
Description
Add a custom key event handler to the terminal to return false for 'Tab' key events so the terminal doesn't intercept app tab navigation (terminal is read-only and doesn't accept Tab). Also remove the code that disabled the terminal textarea so focus/tab navigation and accessibility are preserved.
Screenshots
Release notes
Notes: