Modernize macOS app icon for Tahoe Liquid Glass#21608
Closed
caiofbpa wants to merge 1 commit intodesktop:developmentfrom
Closed
Modernize macOS app icon for Tahoe Liquid Glass#21608caiofbpa wants to merge 1 commit intodesktop:developmentfrom
caiofbpa wants to merge 1 commit intodesktop:developmentfrom
Conversation
cb6a429 to
1d66e8e
Compare
2b78b6f to
3c7ad87
Compare
Closed
Member
|
Would you mind dropping some screenshots of the icon in the various configurations @caiofbpa? |
Contributor
Author
|
@niik I found out an icon sizing bug, I'll fix that and then upload some screenshots as you asked |
3c7ad87 to
bec2c2a
Compare
Contributor
Author
|
@niik I fixed the sizing bug and unfortunately had to force push here again. Here are the screenshots from my local machine: Light mode: Dark mode: |
Contributor
Author
|
Another set of screenshots showing the old icon, development icon and the new proposed icon: 
|
Contributor
Author
|
This version I put together doesn't support well tint mode - I'll try to create a different version soon that works well in all modes |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes GitHub Desktop's macOS app icon assets for macOS Tahoe (26) Liquid Glass behavior.
dark,light, andtintedrendering in.iconmetadata.icnsand PNG logo exports) to match the new variantsContext
Scope
Asset-only change under
app/static/logos:icon-logo.icon/**(production icon variants + metadata)icon-logo-yellow.icon/**(development icon variants + metadata)icon-logo.icnsandicon-logo-yellow.icns256x256,512x512,1024x1024)Review Guide
app/static/logos/icon-logo.icon/icon.jsonand the three variant SVG/PNG assets underAssets/.app/static/logos/icon-logo-yellow.icon/icon.jsonand the three variant SVG/PNG assets underAssets/..icns/PNG outputs align with the variant sources.Validation