Merged
Conversation
Introduce RebaseInteractiveOptions and update rebaseInteractive to accept an options object instead of multiple positional args. Pull GIT_EDITOR from opts, forward hook callbacks (onHookProgress/onHookFailure/onTerminalOutputAvailable) into git execution options, and conditionally add --no-verify. Update callers (reorder and squash) to pass the new options shape. Also add HookCallbackOptions import and a minor formatting tweak to getRebaseSnapshot signature. This centralizes interactive rebase configuration and enables hook/no-verify support.
Change continueRebase/rebaseInteractive to accept a RebaseInteractiveOptions object instead of multiple positional args. Move progressCallback and gitEditor into the options object and wire through additional hooks and flags (onTerminalOutputAvailable, onHookFailure, onHookProgress, noVerify). Update callers in AppStore and unit tests to pass the new options object. Also include minor formatting and destructuring cleanups across app-store.ts for line-wrapping and consistency.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #[issue number]
Description
Adds support for intercepting pre-rebase and post-rewrite hooks during rebasing.
Screenshots
Release notes
Notes: