Update Electron to version 40.1.0#21537
Conversation
Add AGENTS.md documenting a Copilot agent for upgrading Electron and the corresponding Node.js version in GitHub Desktop. Provides step-by-step guidance on which files to change (separating Electron and Node updates into two commits), verification steps (yarn install, yarn build:dev), PR title/description template, recommended commit messages, and important notes (e.g., do not change production in validate-electron-version.ts, .nvmrc uses a v prefix). Includes references for finding breaking changes and current reference versions.
| @@ -0,0 +1,181 @@ | |||
| # AGENTS.md - Copilot Agent Instructions | |||
There was a problem hiding this comment.
When I have made custom agents.. I have followed this Creating custom agents. and this Using GitHub Copilot CLI = custom agents and here is examples
Either way. This file should be at .github/agents/electron-upgrader.agent.md. I believe the top should have a meta day section like:
---
name: electron-upgrader
description: ...
---
Currently, this doesn't show up when you use /agent with Copilot CLI
There was a problem hiding this comment.
I just asked VS Code's agent to create this agent, and then used it 😂 I think there are some mismatches between VS Code's agent and Copilot CLI when looking for agents, but I'll fix that in another PR. Thank you!!
tidy-dev
left a comment
There was a problem hiding this comment.
The upgrade appears to work as expected. ✨
The agent however doesn't show up in Copilot CLI and I think that is just a matter of location and meta data. I will approve in case you want to merge and followup with a PR to move to adjust the upgrader file.
|
please see if the person is using old git on thier pc or mac please ask user to udpate that as well also please add more AI stuff |
Summary
This PR updates Electron from v38.2.0 to v40.1.0.
Node.js is also updated from v22.19.0 to v24.11.1.
Breaking Changes
Electron 39
--disable-color-correct-renderingcommand line switchBrowserWindow.setTrafficLightPosition()andBrowserWindow.getTrafficLightPosition()APIs (usetrafficLightPositionproperty instead)webContents.navigationHistoryto be a read-only propertyElectron 40
webContents.getPrinters()andwebContents.print()(use Web Printing API instead)References