Issue 4574: Allow pull on empty repo#21528
Merged
niik merged 3 commits intodesktop:developmentfrom Mar 5, 2026
Merged
Conversation
niik
requested changes
Feb 19, 2026
Member
niik
left a comment
There was a problem hiding this comment.
Hey @jackfreem, thanks for wanting to contribute. I think these changes are sound but there's one interesting logical consequence of your changes that I'd like you to take a look at
Since remoteName === null already returns early, the null check inside the TipState.Unborn block was always true. Simplify to call fetchButton directly and remove the now-unreachable unbornRepositoryButton method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4574
Closes #4575
Description
Screenshots
Before:
After:
Release notes
Notes: Bug fix: Allow origin fetch on empty repo