Description

When a Buffer with multi-byte characters (like emoji) is pushed, chunk.length returns the byte count (8) instead of the string length (4), causing terminalOutputLength to be inflated. The while loop then over-prunes, removing all chunks and causing firstChunk to be undefined.

TypeError
Cannot read properties of undefined (reading 'length')
Socket.n (app/src/lib/git/core.ts:282:35)
Socket.emit (node:events:531:35)
addChunk (node:internal/streams/readable:561:12)
readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
Socket.Readable.push (node:internal/streams/readable:392:5)
Pipe.onStreamRead (node:internal/stream_base_commons:189:23)

This crash was introduced by #21319 and is on beta right now.

To reproduce create a file with like a megabyte of 😀 emoji and try to view it in the diff viewer.

node -e "process.stdout.end('😀'.repeat(1024*1024))" > emoji.txt

Screenshots

Release notes

Notes: [Fixed] Git output containing multibyte characters is handled correctly avoiding unexpected crashes