Skip to content

Issue 7734: Enter to create new branch#21404

Merged
tidy-dev merged 1 commit intodesktop:developmentfrom
jackfreem:jf/EnterNewPR
Jan 6, 2026
Merged

Issue 7734: Enter to create new branch#21404
tidy-dev merged 1 commit intodesktop:developmentfrom
jackfreem:jf/EnterNewPR

Conversation

@jackfreem
Copy link
Contributor

@jackfreem jackfreem commented Dec 29, 2025

Closes #7734

Description

  • Pressing Enter with a non-matching branch name opens the Create Branch dialog
  • Enter key works for branch selection in merge/rebase dialogs

Screenshots

  • Instructions:
    • Search through branches with a new branch name
    • Press enter -> Confirm this brings you to the create branch page
    • Press enter -> Confirm this creates the new branch
Screenshot 2025-12-29 at 4 07 42 PM Screenshot 2025-12-29 at 4 07 58 PM Screenshot 2025-12-29 at 4 08 06 PM

Release notes

Notes: Enter key now creates new branches from the branch filter field

@github-actions github-actions bot added external Pull request originating outside of the Desktop core team triage For incoming issues labels Dec 29, 2025
@jackfreem jackfreem marked this pull request as ready for review December 29, 2025 21:11
Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Works as expected.

For others looking at this and wondering why?

I am guessing, that on one of the refactors of the filter list, the test box no longer had a type of search.

I was somewhat concerned that this could have potentially broader impact since it is the general TextBox component, but it turns out that in the filter lists is the only place we use a "onEnterPressed" on the textbox component and in turn the only list that uses it is the branch list. I tested in the merge dialog and the pull request dialog and do not see a change of behavior in those use cases.

@tidy-dev tidy-dev merged commit dc5b6c3 into desktop:development Jan 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external Pull request originating outside of the Desktop core team triage For incoming issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hitting Enter doesn't create a new branch when typing its name

3 participants