fix: pull from paginated local vs head-n based on last commit#21066
Conversation
sergiou87
left a comment
There was a problem hiding this comment.
Changes make sense and works as advertised, nice fix!
Only a couple of minor requests before merging.
…2-commit-history-unpublished-indicator
all set, thanks! |
@sergiou87 this should be in a mergable state |
sergiou87
left a comment
There was a problem hiding this comment.
Great work!!! 
And thank you for the ping, it's been a hectic month and I forgot about this 😬 😳
|
@ashdawngary I think you need to run |
Head branch was pushed to by a user without write access
|
Sorry @ashdawngary 😭 But the macOS runner image we used for CI builds just got deprecated, I updated it in #21362 Do you mind updating your branch with the latest Thank you! |
…2-commit-history-unpublished-indicator
all set |
sergiou87
left a comment
There was a problem hiding this comment.
Alll good!! Thanks again for your patience 🙇♂️
Closes #20882
Description
Upgrades
loadLocalCommitsto support paginated loading of local commits. Achieves this via askipparameter which preserves behavior when undefined, otherwise retrieves commits from an offset on a range.The original bug was due to
loadLocalCommitsonly being called once with its initial batch size of 100 (hence why only 100 records will have the local commit tag on them), and the rest were loaded vialoadCommitBatch. Now_loadNextCommitBatchwill choose between loading locally orloadCommitBatchbased on whether the last commit in the flattened page list is a local commit. If the original method fails or produces 0 entries, we use the latter as a backup too.Screenshots
localcommitsfixed.mov
Tests Various conditions (< 100 commits), more than 100 commits etc
Release notes
Fixed issue of only up to 100 unpushed commits loading in history
Notes: