Skip to content

Only sanitize forbidden fs characters when creating repo#20977

Merged
niik merged 2 commits intodevelopmentfrom
belts-and-suspenders
Nov 27, 2025
Merged

Only sanitize forbidden fs characters when creating repo#20977
niik merged 2 commits intodevelopmentfrom
belts-and-suspenders

Conversation

@niik
Copy link
Member

@niik niik commented Sep 5, 2025

Closes #20973

Description

See this discussion in #20973. This PR removes the repository name sanitization entirely on macOS (+Linux) and makes it much more forgiving on Windows, only sanitizing characters that are forbidden on Windows file systems.

Screenshots

Release notes

Notes:

@niik niik merged commit 1b5e247 into development Nov 27, 2025
9 checks passed
@niik niik deleted the belts-and-suspenders branch November 27, 2025 13:12
getRepositoryType,
RepositoryType,
} from '../../lib/git'
import { sanitizedRepositoryName } from './sanitized-repository-name'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a repo from a folder with spaces in its name doesn't work anymore.

3 participants