Fix iframe crash in SandboxedMarkdown with requestAnimationFrame#20761
Merged
tidy-dev merged 1 commit intodevelopmentfrom Jul 14, 2025
Merged
Fix iframe crash in SandboxedMarkdown with requestAnimationFrame#20761tidy-dev merged 1 commit intodevelopmentfrom
tidy-dev merged 1 commit intodevelopmentfrom
Conversation
Wraps iframe src assignment in requestAnimationFrame to prevent a crash in Electron 34 caused by layout changes during ResizeObserver callbacks. Addresses issue #20760.
tidy-dev
approved these changes
Jul 11, 2025
|
This pull request addresses a critical issue with the Fix for Electron 34 crash:
|
|
ok |
|
OPay |
Closed
|
I am currently using the latest version of the Windows version, 3.5.2, but it's very, very slow. It's so slow that it freezes. Whenever I open this program, it starts to freeze, and I can't perform any other operations. What's going on? |
noelportillo
left a comment
There was a problem hiding this comment.
Okay but I think it's time to go
dcano7843
reviewed
Aug 17, 2025
| @@ -360,16 +360,21 @@ export class SandboxedMarkdown extends React.PureComponent< | |||
| // convert non-latin strings that existed in the markedjs. | |||
| const b64src = Buffer.from(src, 'utf8').toString('base64') | |||
| @@ -360,16 +360,21 @@ export class SandboxedMarkdown extends React.PureComponent< | |||
| // convert non-latin strings that existed in the markedjs. | |||
| const b64src = Buffer.from(src, 'utf8').toString('base64') | |||
|
مساعده |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20760
Description
Wraps iframe src assignment in requestAnimationFrame to prevent a crash in Electron 34 caused by layout changes during ResizeObserver callbacks. Addresses issue #20760.
Release notes
Notes: [Fixed] Fix crash opening Pull Request-related notifications