Add support for finding Atom, Visual Studio, and VS Code #2039

shimpossible · 2017-06-17T21:27:43Z

[WIP]
Allow for additional external editors like the old GitHub Desktop. Supports #1554 #2009

… external editor

app/src/lib/dispatcher/app-shell.ts

+    result.push({
+      name: 'Atom',
+    })
+    }


app/src/lib/dispatcher/app-shell.ts

+  if (__DARWIN__) {
+    const osx = require('shell-osx')
+    if (osx.isAtomInstalled()) {
+    result.push({


app/src/lib/dispatcher/app-shell.ts

+  } else {
+    const win32 = require('./shell-win32')
+    if(win32.isVisualStudioInstalled() ) {
+    result.push({


add win32 support

Initial pass, that is super slow..

indicate to the user while its building with 'searching...'

# Conflicts: # app/src/ui/repositories-list/repository-list-item.tsx

app/npm-shrinkwrap.json

-      "version": "0.0.6",
-      "from": "7zip@0.0.6",
-      "resolved": "https://registry.npmjs.org/7zip/-/7zip-0.0.6.tgz",
+      "version": "https://registry.npmjs.org/7zip/-/7zip-0.0.6.tgz",


joshaber · 2017-06-22T11:46:21Z

Ideally we'd allow the user to select whatever application they want, instead of hardcoding a supported list. Otherwise we're likely to get issues asking why we don't support their favorite X editor 😄

I'm not very familiar with Windows—is there a reason to only support a fixed list?

shimpossible · 2017-06-22T21:18:22Z

Being able to edit the list would be nice. I'm just trying to get a list as a first step. Different editors work differently. Vscode and atom can open a directory. Visual studio and xcode require project files. Changing to a dynamic list can be a later bunch of changes.

Not sure how I would change the settings ui to support a dynamic list, as I'm not sure what's needed yet. I can add in some hooks for it and let someone else do the ui change.

Use some defaults if none found

shimpossible · 2017-06-25T13:27:22Z

😄 its configurable now. should work on osx and win
Need to add a settings ui so the user can change things.

Right now I do it in the console

localStorage.setItem('external-editors-.json', '[{"name":"Visual Studio", "cmd":"\\"C:\\\\Program Files (x86)\\\\Microsoft Visual Studio\\\\2017\\\\Community\\\\Common7\\\\IDE\\\\devenv.exe\\" \\"{path}\\""}]')

Might be better to store it by app instead of extension.. not sure yet

saul · 2017-07-05T14:52:08Z

Why not open with the user's default editor for a given extension?

shimpossible · 2017-07-06T11:29:04Z

It already opens with the default editor. Look at #2009
Theyre was also a request to open with multiple editors

app/src/lib/dispatcher/app-shell.ts

  readonly openItem: (path: string) => boolean
  readonly getEditors: (path: string) => Promise<IEditorLauncher[]>
-  readonly setEditors:  (ext: string, info: IEditorInfo) => void
+  readonly setEditors:  (ext: string, info: IEditorInfo[]) => void


# Conflicts: # app/src/lib/dispatcher/app-shell.ts # app/src/ui/preferences/preferences.tsx # app/src/ui/repositories-list/repository-list-item.tsx # package.json

prettify

shimpossible · 2017-07-28T21:16:01Z

🎐

rlabrecque · 2017-07-28T21:33:53Z

Can you show some screenshots of what this looks like now in all the places the UX has changed?

shimpossible · 2017-07-30T20:16:47Z

Right clicking on any file (if it has an association) shows the menu

...
open in external editor
open in

Right click on a repo also shows:
open in

shiftkey · 2017-07-31T15:58:57Z

@shimpossible apologies for not chiming in sooner, but I think we need to revisit the scope for this feature in 1.0 and keep it focused.

I wrote up some details in the original issue #2009 (comment) - could you have a look at that?

shimpossible · 2017-08-03T20:17:20Z

I agree. This quickly got complicated. And I needs a design that everyone agrees on. But I had already started down the path and wanted to finish. If this doesn't get used, or get refactored into something better that's fine

aalvrz · 2017-08-09T15:50:37Z

I remember some time ago using Github Desktop for Windows and it automatically could find Atom editor when it was installed in my machine. I could open the editor with the whole repository by clicking on the Atom logo shown on the top-right corner of Github Desktop.

However recently I downloaded and installed Github desktop and it looks completely different. Here is what it looked like before, sort of:

Can anyone tell me what happened? Was the whole UI changed? I could not find any mention of this in the release notes.

joshaber · 2017-08-09T16:12:13Z

Can anyone tell me what happened?

Yes! The version you downloaded is the GitHub Desktop Beta. You can read more about it at https://github.com/blog/2362-announcing-git-integration-for-atom-and-github-desktop-beta.

If you want to download the Classic apps, scroll to the bottom of https://desktop.github.com for the links.

aalvrz · 2017-08-09T16:21:36Z

@joshaber

Thanks for that. So if I understand correctly, Github Desktop Beta (the one I used before and the one that supported Atom Editor) had separate and different code bases for each platform. However a decision was made to re-write Github Desktop using Electron so that this new single code base (this repository I assume) could work accross all platforms.

Hope the above is correct. And sorry for sort of hijacking this issue.

shimpossible · 2017-08-09T16:43:40Z

There is a new version of desktop that is built in typescript. It's listed as beta. If you scroll down to the bottom of https://desktop.GitHub.Com there is a link to the old one

shiftkey · 2017-08-15T02:32:57Z

@shimpossible thanks for your work on getting this going, but we ended up merging #2407 which will go out in the next update. Please feel free to open issues against it, so we can refine it down the track!

Add support for finding Atom, Visual Studio, and VS Code to use as an…

dd1b6a4

… external editor

j-f1 suggested changes Jun 17, 2017

View reviewed changes

shimpossible added 10 commits June 17, 2017 16:46

make lint happy

e161690

add win32 support

add check for VS Code in OSX

2b723cd

add winreg to shrinkwrap

af301bb

refactor shell-win32.ts to use callbacks

550850d

make lint happy

4718d39

hook up external editor list to repo menu.

aa1be27

Initial pass, that is super slow..

Build list of editors on load of repo list to save time

118f86f

indicate to the user while its building with 'searching...'

make lint happy

7862e44

Merge branch 'master' into external-editors

1024b18

# Conflicts: # app/src/ui/repositories-list/repository-list-item.tsx

add Atom editor to search

6567310

shiftkey reviewed Jun 21, 2017

View reviewed changes

app/npm-shrinkwrap.json

"version": "0.0.6",

"from": "7zip@0.0.6",

"resolved": "https://registry.npmjs.org/7zip/-/7zip-0.0.6.tgz",

"version": "https://registry.npmjs.org/7zip/-/7zip-0.0.6.tgz",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

shimpossible added 2 commits June 21, 2017 18:15

revert shrinkwrap

be0959f

add winreg back to shrinkwrap

6cb027e

shimpossible added 4 commits June 23, 2017 16:36

read external editors from localStorage

f8f7530

run external editor list from localStorage to allow for customization.

9ff8175

Use some defaults if none found

Add editors to changed file list

1db9097

log what is about to be executed before it runs

ef23900

shimpossible added 3 commits July 10, 2017 21:59

add ui for editing file editors by extension

6ac10e9

save lines when they update

108b822

allow deleting of editors

bf5cba3

j-f1 reviewed Jul 14, 2017

View reviewed changes

add ui for adding extension handlers

28f0b68

rlabrecque mentioned this pull request Jul 27, 2017

Open Repository in External Editor #2009

Closed

shimpossible added 5 commits July 28, 2017 06:49

Merge branch 'master' into external-editors

ae0e94b

# Conflicts: # app/src/lib/dispatcher/app-shell.ts # app/src/ui/preferences/preferences.tsx # app/src/ui/repositories-list/repository-list-item.tsx # package.json

make lint happy

0b4cd52

implement adding editors

92fb74d

prettify

clean up ui

09374ad

prettify

de94a76

shimpossible changed the title ~~[WIP] Add support for finding Atom, Visual Studio, and VS Code~~ Add support for finding Atom, Visual Studio, and VS Code Jul 28, 2017

shiftkey mentioned this pull request Aug 6, 2017

Open in External Editor, But Simpler™ #2407

Merged

22 tasks

shiftkey closed this Aug 15, 2017

stevemoser mentioned this pull request May 30, 2018

Add Xcode to list of supported 'open in' editors #4825

Closed

billygriffin mentioned this pull request Mar 7, 2019

Desktop doesn't cleanly integrate with my editor (user feedback desired) #7033

Closed

Add support for finding Atom, Visual Studio, and VS Code #2039

Add support for finding Atom, Visual Studio, and VS Code #2039

Uh oh!

Conversation

shimpossible commented Jun 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

joshaber commented Jun 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shimpossible commented Jun 22, 2017

Uh oh!

shimpossible commented Jun 25, 2017

Uh oh!

saul commented Jul 5, 2017

Uh oh!

shimpossible commented Jul 6, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shimpossible commented Jul 28, 2017

Uh oh!

rlabrecque commented Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shimpossible commented Jul 30, 2017

Uh oh!

shiftkey commented Jul 31, 2017

Uh oh!

shimpossible commented Aug 3, 2017

Uh oh!

aalvrz commented Aug 9, 2017

Uh oh!

joshaber commented Aug 9, 2017

Uh oh!

aalvrz commented Aug 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shimpossible commented Aug 9, 2017

Uh oh!

shiftkey commented Aug 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shimpossible commented Jun 17, 2017 •

edited

Loading

joshaber commented Jun 22, 2017 •

edited

Loading

rlabrecque commented Jul 28, 2017 •

edited

Loading

aalvrz commented Aug 9, 2017 •

edited

Loading