Skip to content

Remove duplicate avatar users#19633

Merged
niik merged 1 commit intodevelopmentfrom
remove-duplicate-avatar-users
Dec 2, 2024
Merged

Remove duplicate avatar users#19633
niik merged 1 commit intodevelopmentfrom
remove-duplicate-avatar-users

Conversation

@niik
Copy link
Member

@niik niik commented Nov 29, 2024

Closes #19597

Description

Remove duplicate avatar users based on name and email.

Screenshots

Release notes

Notes:

Copy link

@marlonwq marlonwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment saying what this does above the code

Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖 After I left the comment on the original ticket, I thought using a set might be a good way to go here and was going to circle back and comment as such. But happy surprise, you already fixed it!

@niik niik merged commit 79a3813 into development Dec 2, 2024
@niik niik deleted the remove-duplicate-avatar-users branch December 2, 2024 17:43
@Snoopy1866
Copy link

Sorry to bother you. If a user changes his or her username, duplicate avatars may still appear in the commit details. I'm using Github Desktop Version 3.4.17-beta3 (x64).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate co-author show duplicate avatar.

4 participants