Fix for indents of clear button in text box#19615
Merged
tidy-dev merged 1 commit intodesktop:developmentfrom Nov 27, 2024
Merged
Fix for indents of clear button in text box#19615tidy-dev merged 1 commit intodesktop:developmentfrom
tidy-dev merged 1 commit intodesktop:developmentfrom
Conversation
tidy-dev
approved these changes
Nov 26, 2024
Contributor
tidy-dev
left a comment
There was a problem hiding this comment.
💖 Thank you for the quick fix! Tested it across various use cases and work great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19613
Description
Suggested a small fix with the positioning of the button and the close icon inside the button in
text-boxScreenshots
Release notes
Notes:
I returned a height variable for the button, since the button has position absolute and occupies the highest block height.