New context menu item on branch toolbar and pull requests list#19505
New context menu item on branch toolbar and pull requests list#19505tidy-dev merged 7 commits intodesktop:developmentfrom
Conversation
tidy-dev
left a comment
There was a problem hiding this comment.
@DylanDevelops This is most definitely the right direction!
I have one change we have to have for accessibility, and then another suggested change that is for less verbose code. :) Thanks for such a quick turn around.
This change should produce clearer code
|
@tidy-dev Let me know if these changes are what you were asking for! |
tidy-dev
left a comment
There was a problem hiding this comment.
Thank you for those fixes! I tested and I can invoke this context menu with the keyboard. 🎉
After reviewing the code and seeing where we now have the item with the PullRequest object on it from the list component callback. I put a suggestion where I think we can tighten up the code just a little further. It also takes away any possible ambiguity in the difference between the context menu item and the "selectedPullRequest".. which are only the same thing after the right click event has fired.. and with keyboard focus/clicking/selecting possibly being different when using a screenreader. I think it would be cleaner to make sure we are talking about the same thing at the same time. :D (FWIW, it works with screen readers, just screen reader support seems to change out from under us regularly).
|
@tidy-dev How does this look? |
tidy-dev
left a comment
There was a problem hiding this comment.
💖 Thank you for all the iterations. Looks good!
|
Thank you, @tidy-dev, for mentoring me! :) |
Closes #19453
Description
Note: I did not add an item to the context menu for each branch that shows on the branches list. I am not sure if this is something you wanted me to do or not. You can see what I added in the screenshots below.
Screenshots
Checked-Out Branch Toolbar Context Menu
Pull Request List Context Menu
Release notes
Notes: [ADDED] Add "View Pull Request on GitHub" Option to the Checked-Out Branch Button and Pull Requests List
(You can make this sound better as I am not 100% sure how to phrase this)