Don't show certificate error dialog when probing for endpoint kind#19297
Merged
sergiou87 merged 5 commits intodevelopmentfrom Sep 30, 2024
Merged
Don't show certificate error dialog when probing for endpoint kind#19297sergiou87 merged 5 commits intodevelopmentfrom
sergiou87 merged 5 commits intodevelopmentfrom
Conversation
sergiou87
reviewed
Sep 24, 2024
Member
sergiou87
left a comment
There was a problem hiding this comment.
Looks good overall! Just wondering about a specific return false and whether or not it should be return true 🤔
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
✨
This was referenced Sep 30, 2024
|
Did not work for me still the popups "untrusted server" showing on Version 3.4.6 (x64) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18991
Supersedes #19149
Description
This PR supersedes #19149. Crucially this PR does not abandon the use of the Chromium network stack (by using the http/https node modules). Instead it suppresses the certificate error dialog for the specific probing URL by means of keeping track of a set of urls for which we shouldn't prompt for certificate errors.
Additionally this PR reduces the likelihood that Desktop makes a probing request in the first place by checking for the existence of several known third-party realms and assuming that a hostname of the format
github.somecorp.tldis a GitHub Enterprise Server instance.-->
Release notes
Notes: