Unset GIT_SEQUENCE_EDITOR when rebasing#19278
Merged
sergiou87 merged 1 commit intodevelopmentfrom Sep 27, 2024
Merged
Conversation
tidy-dev
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15413
Description
When a user launches GitHub Desktop from a shell that has the GIT_SEQUENCE_EDITOR environment variable set Git will launch the executable specified in that variable on every step of the rebase process. We already set
sequence.editorhere:desktop/app/src/lib/git/rebase.ts
Line 586 in 52c0767
But the environment variable takes precedence.
So we'll explicitly unset the GIT_SEQUENCE_EDITOR before launching the rebase.
Screenshots
Release notes
Notes: