Remove staggered updates block in about dialog#19274
Merged
tidy-dev merged 2 commits intodevelopmentfrom Sep 25, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19241
Description
GitHub Desktop conducts staggered rollouts of updates in order to detect regressions quickly while reducing impact. There is a block in the about dialog such that if a staggered update has not reached that users build yet; they cannot update via auto updates or hitting the check for updates button. However, we built in a bypass that if you held down the
Altkey the check for updates button in the about dialog, you could bypass the block and go ahead and download the latest update. A user could also bypass the staggered rollouts by going to the download page and downloading and installing the latest version there.This PR removes the block in the About dialog. Thus, auto-updates will be remain staggered. But, if a user goes to the about dialog, they can go ahead and get the latest.
We believe the friction of going to the about dialog is enough and that the vast majority of users will just wait for the auto-update. This should be enough to provide the benefit of staggered rollouts that enable us to detect regressions early and reduce user impact.
This PR should reduce the support burden we have received of users wanting to know why they cannot update when there is a new version that we generally see every release.
Screenshots
For testing, I disabled the "development" checks that prevent rending of the button and just ensured that the checkForUpdates is called with the skipGuidCheck.
Release notes
Notes: [Removed] Remove staggered updates block in about dialog