Skip to content

Remove staggered updates block in about dialog#19274

Merged
tidy-dev merged 2 commits intodevelopmentfrom
remove-alt-key-requirement-to-bypass-update-rollout
Sep 25, 2024
Merged

Remove staggered updates block in about dialog#19274
tidy-dev merged 2 commits intodevelopmentfrom
remove-alt-key-requirement-to-bypass-update-rollout

Conversation

@tidy-dev
Copy link
Contributor

Closes #19241

Description

GitHub Desktop conducts staggered rollouts of updates in order to detect regressions quickly while reducing impact. There is a block in the about dialog such that if a staggered update has not reached that users build yet; they cannot update via auto updates or hitting the check for updates button. However, we built in a bypass that if you held down the Alt key the check for updates button in the about dialog, you could bypass the block and go ahead and download the latest update. A user could also bypass the staggered rollouts by going to the download page and downloading and installing the latest version there.

This PR removes the block in the About dialog. Thus, auto-updates will be remain staggered. But, if a user goes to the about dialog, they can go ahead and get the latest.

We believe the friction of going to the about dialog is enough and that the vast majority of users will just wait for the auto-update. This should be enough to provide the benefit of staggered rollouts that enable us to detect regressions early and reduce user impact.

This PR should reduce the support burden we have received of users wanting to know why they cannot update when there is a new version that we generally see every release.

Screenshots

For testing, I disabled the "development" checks that prevent rending of the button and just ensured that the checkForUpdates is called with the skipGuidCheck.

CleanShot 2024-09-17 at 12 09 42

Release notes

Notes: [Removed] Remove staggered updates block in about dialog

Copy link
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tidy-dev tidy-dev merged commit 98755e9 into development Sep 25, 2024
@tidy-dev tidy-dev deleted the remove-alt-key-requirement-to-bypass-update-rollout branch September 25, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve secret option "Ensure Latest Version"

2 participants