Merged
Conversation
sergiou87
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: https://github.com/github/accessibility-audits/issues/5574
Description
This PR adds the ability to prefix our textboxes with an icon. Then, it uses that to apply a search icon in front of all of our filter text boxes in the section filter list component (which I think is all of them). Also, the update branch dialog had some css that needed adjusted to work with the new icon placement.
This improves accessibility by providing a visual label for our search inputs (along with the placeholder text of "filter").
Other notes: I tested on dark mode as well. In both light and dark, the icon not only meets 3:1 but 4.5:1 contrast.
Screenshots
Release notes
Notes: [Improved] Added search input visual labeling in the form of a search icon.