Merged
Conversation
sergiou87
requested changes
Jan 19, 2024
Member
sergiou87
left a comment
There was a problem hiding this comment.
Changes make sense, and it works fine in the small avatars, but for some reason the avatar doesn't show up in avatar tooltips:
| * | ||
| * Most often used to check if an endpoint _isn't_ GitHub.com meaning it's | ||
| * either GitHub Enterprise Server or GitHub AE | ||
| * Whether or not the given endpoint belong's to GitHub.com |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| * Whether or not the given endpoint belong's to GitHub.com | |
| * Whether or not the given endpoint belongs to GitHub.com |
Member
|
I made a couple of fixes:
|
tidy-dev
reviewed
Jan 30, 2024
app/src/ui/lib/avatar.tsx
Outdated
| const knownAvatars: ReadonlyArray<IAvatarUser> = [ | ||
| ...dotComBot('dependabot[bot]', 49699333, 29110), | ||
| ...dotComBot('github-actions[bot]', 41898282, 15368), | ||
| ...dotComBot('github-pages[bot] ', 52472962, 34598), |
Contributor
There was a problem hiding this comment.
Curious why the github-pages[bot] has space after it's login?
Member
There was a problem hiding this comment.
🤯 and it's a tab, not just a bunch of spaces
I didn't notice it, nice catch! It might have been an issue interacting with the IDE for autocompletion / Copilot suggestions. I'll remove it. Thanks 🙏
Co-Authored-By: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
sergiou87
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12766
Description
This adds support for loading avatars of "bot accounts", i.e. integrations by means of resolving the user model via the API and using the avatarURL from it. Ideally the avatars endpoint would support resolving this directly from the stealth email but it doesn't so we'll do this little dance to get around it.
Bot avatars are loaded via the id of the integration (i.e. GitHub App) that they belong to. That id is static which means we can preload some known avatars (on GitHub.com only, not GHES) to avoid having to do an API hit when we encounter them. For now I've added the dependabot, github-actions, and github-pages bots and we can add more as we encounter them later.
Screenshots
Release notes
Notes: [Fixed] Show avatars of bot accounts such as dependabot