Merged
Conversation
billygriffin
previously approved these changes
Jan 25, 2021
Contributor
billygriffin
left a comment
There was a problem hiding this comment.
Oh wow this is cool! I'd love another reviewer but conceptually this is great. ❤️
niik
requested changes
Jan 25, 2021
Member
niik
left a comment
There was a problem hiding this comment.
This is great @say25 thanks so much for fixing this. The only ask I have is if we could just check if __RELEASE_CHANNEL__ === 'beta' inside of releases.ts? I'm not super fond of overloading the feature-flag method for this as it's not conceptually what we want to be checking for.
It would also match how we determine which release notes to pull down to show in the release-notes dialog:
desktop/app/src/lib/release-notes.ts
Line 86 in 6b65413
b48ab00 to
f823159
Compare
niik
approved these changes
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3385
Description
Inspired by #11445, thanks @billygriffin
Release notes
Notes: Beta Release Notes Point to the correct place