-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Closed
Labels
bugConfirmed bugs or reports that are very likely to be bugsConfirmed bugs or reports that are very likely to be bugsinfrastructureIssues and pull requests related to scripts and tooling for GitHub DesktopIssues and pull requests related to scripts and tooling for GitHub Desktoppriority-3Bugs that affect small number of users and/or relatively cosmetic in natureBugs that affect small number of users and/or relatively cosmetic in nature
Description
I was having trouble getting the test suite to pass on the main branch. This was because I had these lines in my ~/.gitconfig.
# If these lines exists a dozen tests will fail!
[branch]
autosetuprebase = always
It looks like it is problematic to rely on the user's .gitconfig file. A possible solution would be to unset the HOME env var in the test scripts, but I'm not sure how well that would work on windows.
Proposed Solution
@kuychaco @probablycorey @billygriffin and @outofambit discussed this further and agreed upon the following plan for now:
conflictStyle = diff3will be resolved once Number of merge conflicts are incorrect in merge hint #8049 is finished (and its currently in progress), so we'll let that go for nowautosetuprebase = alwaysis a value we should set tofalsein the setup of tests that will fail without it. (see review unit tests and make config setup more explicit #6972 for an example of this approach)
there's still the open question of using a standard config (or a series of them) for our tests, but i think we're punting on that for now!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugConfirmed bugs or reports that are very likely to be bugsConfirmed bugs or reports that are very likely to be bugsinfrastructureIssues and pull requests related to scripts and tooling for GitHub DesktopIssues and pull requests related to scripts and tooling for GitHub Desktoppriority-3Bugs that affect small number of users and/or relatively cosmetic in natureBugs that affect small number of users and/or relatively cosmetic in nature
Type
Fields
Give feedbackNo fields configured for issues without a type.