Skip to content

stash menu item should not be enabled when a dialog is active #7689

New issue
New issue
Closed
#21435
Closed
stash menu item should not be enabled when a dialog is active#7689
#21435
Labels
bugConfirmed bugs or reports that are very likely to be bugshelp wantedIssues marked as ideal for external contributorspriority-3Bugs that affect small number of users and/or relatively cosmetic in nature
@shiftkey

Description

@shiftkey
shiftkey
opened on Jun 5, 2019

Description

A bit of polish to the new menu item for viewing the current stash

Version

  • GitHub Desktop: 2.0.0
  • Operating system: macOS 10.14.5

Steps to Reproduce

  1. Create a stash on the current branch
  2. View the stash
  3. Press Discard to show the confirmation dialog
  4. Open the View menu

Expected Behavior

Show/Hide stashed changes is disabled, like some other menu items under View

Actual Behavior

Show/Hide stashed changes is enabled, and can be switched while viewing a dialog leading to some confusion:

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugConfirmed bugs or reports that are very likely to be bugshelp wantedIssues marked as ideal for external contributorspriority-3Bugs that affect small number of users and/or relatively cosmetic in nature

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions