-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Description
Please describe the problem you think should be solved
For the longest time we've had the ability to discard all changes by right-clicking the "Changes" header:
This was available on at least the classic Windows app, and it came over in #1647 because we needed somewhere to keep this functionality. Context menus for non-interactive elements like headers aren't very intuitive, but we marched on.
Then we added it to the context menu for a changed file in #4188 (requested in #4314):
This has lead to some confusion in #5342 because it is right next to the "Discard Change" menu item, and if a user doesn't have the "Confirm Discard Changes..." setting enabled they could accidentally move all the files to the trash.
This combination of "header context menu" and "item context menu" makes me think that neither place is the right place for this functionality.
[Optional] Do you have any potential solutions in mind?
in #5342 (comment) we identified a list of changes that will help us to improve this area:
I think we can solve this through implementing these four things, I believe in this order:
- Remove
Discard All Changesfrom file context menu- Add
Discard All Changesas a top menu item- Remove
Discard All Changesfrom the header context menu- Add a UI menu to the changes top bar (containing
Discard All Changesand potential future actions)For anyone who picks this up:
For 2, I think
Discard All Changesshould live inBranch>Discard All Changesin a new section between the first and the second section.For 4, I think we can wait and see how 1-3 feels first before implementing.

