Skip to content

backport fixes from rebase conflicts dialog review to merge conflicts #7043

@shiftkey

Description

@shiftkey

Some things uncovered in #6961 that should be brought back to the Merge Conflicts dialog once #6961 is merged:

<DialogHeader
title={headerTitle}
dismissable={true}
onDismissed={this.onDismissed}
/>

And also for the Merge Branch selector:

<DialogHeader
title={
<div className="merge-dialog-header">
Merge into <b>{currentBranchName}</b>
</div>
}
dismissable={true}
onDismissed={this.props.onDismissed}
/>
<DialogContent>

  • these colours should be replaced with variables defined in variables.scss values (or add new values) to ensure they can be styled correctly with different themes

.unmerged-file-status-resolved .file-conflicts-status {
color: $green;
}
.unmerged-file-status-conflicts {
.file-conflicts-status {
color: $orange;
}
.command-line-hint {
color: $gray;
}
}

.arrow-menu,
.resolve-arrow-menu {
.octicon {
width: 10px;
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedIssues marked as ideal for external contributorstech-debtIssues and pull requests related to addressing technical debt or improving the codebase

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions