-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Closed
Labels
help wantedIssues marked as ideal for external contributorsIssues marked as ideal for external contributorstech-debtIssues and pull requests related to addressing technical debt or improving the codebaseIssues and pull requests related to addressing technical debt or improving the codebase
Description
Some things uncovered in #6961 that should be brought back to the Merge Conflicts dialog once #6961 is merged:
- add support for setting JSX for title on Dialog props #6032 means we should set
Dialog.titleto a JSX element (and update the CSS because of the DOM changes)
desktop/app/src/ui/merge-conflicts/merge-conflicts-dialog.tsx
Lines 244 to 248 in 5d9eab1
| <DialogHeader | |
| title={headerTitle} | |
| dismissable={true} | |
| onDismissed={this.onDismissed} | |
| /> |
And also for the Merge Branch selector:
desktop/app/src/ui/merge-branch/merge.tsx
Lines 262 to 271 in b552932
| <DialogHeader | |
| title={ | |
| <div className="merge-dialog-header"> | |
| Merge into <b>{currentBranchName}</b> | |
| </div> | |
| } | |
| dismissable={true} | |
| onDismissed={this.props.onDismissed} | |
| /> | |
| <DialogContent> |
- these colours should be replaced with variables defined in
variables.scssvalues (or add new values) to ensure they can be styled correctly with different themes
desktop/app/styles/ui/dialogs/_merge-conflicts.scss
Lines 83 to 95 in 5d9eab1
| .unmerged-file-status-resolved .file-conflicts-status { | |
| color: $green; | |
| } | |
| .unmerged-file-status-conflicts { | |
| .file-conflicts-status { | |
| color: $orange; | |
| } | |
| .command-line-hint { | |
| color: $gray; | |
| } | |
| } |
- the arrow octicon should have an explicit height and width if set in CSS - more context here [rebase] menu item and dialog to start rebase operation #6961 (comment)
desktop/app/styles/ui/dialogs/_merge-conflicts.scss
Lines 109 to 114 in 5d9eab1
| .arrow-menu, | |
| .resolve-arrow-menu { | |
| .octicon { | |
| width: 10px; | |
| } | |
| } |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
help wantedIssues marked as ideal for external contributorsIssues marked as ideal for external contributorstech-debtIssues and pull requests related to addressing technical debt or improving the codebaseIssues and pull requests related to addressing technical debt or improving the codebase