-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Closed
Description
Reproduce:
- Start with a branch that has 1 or more untracked files.
- Merge another branch, like master, into branch, such that conflicts will arise (should NOT be changes that track above file(s)).
- Merge Conflict dialog pops up.
- Resolve merge conflicts in editor (do not remove untracked files).
- Press "Commit Merge" button.
- See error: "Could not generate a patch for file foo/bar, patch empty".
- Now you are stuck.
Work arounds:
- Move (temporarily) the untracked file(s).
- Run
git add foo/baroutside of the app.
Neither are particularly pleasing options.
Preferred Solutions:
- Quietly skip untracked files for the merge, unless, of course, the merge adds them. Committing anything that didn't come from the merge makes no sense from the merge's perspective. (Preferred)
- Do (1) and offer options to add or skip untracked. (Ok, but messier merge)
- Allow me to exit the dialog and commit when I'm ready, which is sort of how it was before the Merge Conflict dialog was added. (Ok, less messy than (2), but not great)
- Warn me that the merge cannot be started with untracked files present, which is hardly better than doing nothing. (Meh, I'll just end up do work around 1 anyway)
Reactions are currently unavailable