-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Closed
Labels
bugConfirmed bugs or reports that are very likely to be bugsConfirmed bugs or reports that are very likely to be bugselectronIssues related to our use of Electron that may need updates to Electron or upstream fixesIssues related to our use of Electron that may need updates to Electron or upstream fixesmacOSIssues specific to Desktop usage on macOSIssues specific to Desktop usage on macOSpriority-3Bugs that affect small number of users and/or relatively cosmetic in natureBugs that affect small number of users and/or relatively cosmetic in nature
Milestone
Description
Description
On macOS, the GitHub desktop window can't be closed if it is fullscreen (in its own space rather than on a desktop space, i.e. not maximized); it can only be closed if the window is not in fullscreen mode.
Version
- GitHub Desktop: 1.3.0
- Operating system: macOS 10.13.6
Steps to Reproduce
- Enter fullscreen using either the green title bar button, View menu > "Toggle Full Screen", or using the command-control-F keyboard shortcut.
- Attempt to close the window using either the red title bar button, Window menu > "Close window", or using command-W.
Expected Behavior
The window should close.
Actual Behavior
The window stays open.
Logs
I do not have access to the log at the moment, but will attach it later unless it's not considered necessary for this issue.
Metadata
Metadata
Assignees
Labels
bugConfirmed bugs or reports that are very likely to be bugsConfirmed bugs or reports that are very likely to be bugselectronIssues related to our use of Electron that may need updates to Electron or upstream fixesIssues related to our use of Electron that may need updates to Electron or upstream fixesmacOSIssues specific to Desktop usage on macOSIssues specific to Desktop usage on macOSpriority-3Bugs that affect small number of users and/or relatively cosmetic in natureBugs that affect small number of users and/or relatively cosmetic in nature