Skip to content

List of changes doesn't update automatically after "There are no changes to commit." error #21229

@DecimalTurn

Description

@DecimalTurn

The problem

When the "There are no changes to commit." error occurs (after trying to add changes from the worktree that disapear during the staging process), the list of changes should refresh to show that there is no changes without the user having to go to the history tab (or de-focus and re-focus the window).

Release version

3.5.3

Operating system

Windows 11

Steps to reproduce the behavior

  1. Run the following bash script
# Initialize a new git repository
git init ghd-test
cd ghd-test
echo '* text=auto' > .gitattributes
git add .gitattributes
git commit -m 'Initial'

# Create a file with LF line endings
printf 'Hello\nWorld\n' > Hello.txt
git add Hello.txt
git commit -m 'LF'
  1. Open VS Code and change the line endings of Hello.txt to CRLF
  2. Open GitHub Desktop and notice the detected changes
  3. Try to commit changes
  4. Click "Close" on the error message
  5. Wait... (the list of changes won't update)

Log files

No response

Screenshots

Just to confirm, this is what I have in the .gitattributes file

Image

Additional context

GitHub-Desktop-Demo.mp4

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugConfirmed bugs or reports that are very likely to be bugs

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions