-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Closed
Labels
design-input-neededIssues that require design input from the core team before the work can be startedIssues that require design input from the core team before the work can be startedenhancementnot-plannedNot in the team's roadmapNot in the team's roadmap
Description
Describe the feature or problem you’d like to solve
I think it would be neat if GitHub Desktop prominently notified me if a hook rejects the commit I'm trying to make.
Certain hooks (like extensive lint, type check) can take a few seconds. On a couple of occasions, I've gone back to editing the code, assuming the checks will eventually pass. However, when a lint hook rejected the commit, I was not alerted. I did not notice that the commit had failed until after I made another batch of changes and came back to make another commit. I ended up with a single commit containing both changesets, which made it harder to review.
Proposed solution
I would like GitHub Desktop to prominently notify me when a hook rejects the commit. This could come in the form of a notification or a dock icon bounce on macOS.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
design-input-neededIssues that require design input from the core team before the work can be startedIssues that require design input from the core team before the work can be startedenhancementnot-plannedNot in the team's roadmapNot in the team's roadmap
Type
Fields
Give feedbackNo fields configured for issues without a type.