Skip to content

Further clean up scroll#9433

Merged
nbolton merged 3 commits intomasterfrom
scrollCleanup
Feb 9, 2026
Merged

Further clean up scroll#9433
nbolton merged 3 commits intomasterfrom
scrollCleanup

Conversation

@sithlord48
Copy link
Copy Markdown
Member

@sithlord48 sithlord48 commented Feb 6, 2026

Description

Initial clean up of items in the Screen classes.

  • New Coordinate in type in common (aliased as ScrollDelta for our use here)
  • Moved the applyScrollModifier to ISecondaryScreen
  • Use ScrollDelta for all fakeMouseWheel impls
  • Remove wrapping from the settings scroll scale spinbox , set its step to 0.1

How Has This Been Tested?

Tested on non windows platforms scrolling still works.

@sithlord48 sithlord48 requested a review from a team February 6, 2026 15:01
@sithlord48 sithlord48 requested a review from nbolton as a code owner February 6, 2026 15:01
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2026

CI Summary

Test result

❌🔬 Tests failed: 38

OS Unit tests Legacy tests
archlinux-x86_64 ✅ Pass ✅ Pass
debian-arm64 ✅ Pass ✅ Pass
debian-testing-arm64 ✅ Pass ✅ Pass
debian-testing-x86_64 ✅ Pass ✅ Pass
debian-x86_64 ✅ Pass ✅ Pass
fedora-42-arm64 ✅ Pass ✅ Pass
fedora-42-x86_64 ✅ Pass ✅ Pass
fedora-43-arm64 ✅ Pass ✅ Pass
fedora-43-x86_64 ✅ Pass ✅ Pass
macos-arm64 ✅ Pass ✅ Pass
macos-x64 ✅ Pass ✅ Pass
opensuse-arm64 ✅ Pass ✅ Pass
opensuse-x86_64 ✅ Pass ✅ Pass
ubuntu-25.10-arm64 ✅ Pass ✅ Pass
ubuntu-25.10-x86_64 ✅ Pass ✅ Pass
ubuntu-26.04-arm64 ✅ Pass ✅ Pass
ubuntu-26.04-x86_64 ✅ Pass ✅ Pass
windows-2022-arm64 ✅ Pass ✅ Pass
windows-2022-x64 ✅ Pass ✅ Pass

Full summary (scroll down)

@sithlord48 sithlord48 mentioned this pull request Feb 6, 2026
6 tasks
@nbolton nbolton merged commit 1c99736 into master Feb 9, 2026
34 checks passed
@nbolton nbolton deleted the scrollCleanup branch February 9, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants