Merged
Conversation
1c3edf0 to
81080f8
Compare
Contributor
Author
|
Side note - after rebasing on master, I'm getting the following error while attempting to build for Windows:
|
sithlord48
reviewed
Sep 18, 2024
Member
sithlord48
left a comment
There was a problem hiding this comment.
The initial commit can be dropped as its just changed completely by the second one.
Otherwise looks pretty good. Testing on inputleap
6 tasks
4538a84 to
9893d80
Compare
|
Member
|
Thanks for the PR, we're currently renaming the project and I'm in the process of restoring CI functionality. |
sithlord48
reviewed
Sep 18, 2024
9893d80 to
44daa10
Compare
44daa10 to
2bf5ede
Compare
f63a63d to
c0c20c8
Compare
sithlord48
reviewed
Sep 18, 2024
c0c20c8 to
4a044a9
Compare
sithlord48
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by: #7522
On exiting a screen, deskflow attempts to unset keys that are down while leaving the screen. In some cases, such as with Wayland (EiScreen), the keys are reset but after the device emulation has already ended by
Screen::leave(). This leaves the keys in the pressed state since the reset will fail after emulation stops, and may leave the keys stuck pressed until the environment implementing libei is restarted (such as with Kwin).This pull request splits
Screen::leave()intoScreen::canLeave()andScreen::leave(), allowing for the keys to be reset in between.Basically:
Check for screen leave allowed -> Reset keys -> Actually leave
Resolves: #7518