@spurin Oh! getenv! Great idea. Very mergeable and easier than fiddling with CLI args. I'll test in the morning 👍

Edit: I'll get to the bottom of why the Windows runner is failing at the deps step. Quite certain that it's a cache issue totally unrelated to your PR.

Regarding the setting of 2x that I'm using, the mouse speed is perfect and consistent now.

I wonder on the explanation for this.

I have 2 x 4K screens, 3840x2160

Mac Retina is a 1080p "like" resolution on a 4K screen, providing that retina sharpness and crispness by pixel doubling.

My windows desktop is 4K, albeit with a percentage zoom in.

I believe that the retina aspect on mac may be treating the pixel count as a 1080p screen, when we switch to windows, the pixel count is double, hence the slow down of the mouse movement.

Coincidently, when I tried Share Mouse, I also needed to move the bar to 200% to get the equivalent result.

Mentioning this as retina mode is standard on Mac OS and it may be worthwhile thinking about this from a UI/settings implementation.

As the user, I can recommend rounding fractional numbers to the 1 because having a 0.5 coefficient means the mouse won't move during 1px movements. It wasn't enjoyable. Because of that, I implemented flooring (instead of rounding) with my limited knowledge of C++.

@spurin Heads up, we're renaming the upstream 'Synergy Community Edition' to Deskflow. Once that's done we can work on getting this PR merged. Sorry for the delay. Discussion: #7517

Thanks for the heads up, interesting name. I like it!

Would it be possible to make this part of the client/server config ?

Would it be possible to make this part of the client/server config ?

I think so. Env var is good for developer testing, but for regular users, config would be easier.

@sithlord48 Edit: In the interest of moving forward, maybe we should do the GUI config stuff in a separate PR?

@spurin Would you like us to fix the SonarCloud-idenfied smells or would you prefer we do it?

@nbolton I'm more than happy for yourself or anybody to take this on and use/re-use/update the code as required to make it useful for the task in hand.

For context, I treated this as a functional prototype and for my own personal needs at present it suits me well.

Whilst I'd rather have the slick features of Synergy 3, the mouse aspect is currently more important at present (am doing a lot of design/creative work between mac and windows). So I'm happy to live with this workaround until it takes a better form in the future.

You steer your own ship much better than I, appreciate the ask. In this case please do as you see fit with it 👍

I'm more than happy for yourself or anybody to take this on

@spurin No problem, I'll take a look at getting these issues fixed soon so we can merge this in. I appreciate the time you've spent so far and thanks for sharing your solution with us.

Would it be possible to make this part of the client/server config ?

@sithlord48 What did you think about doing the config improvements in a new PR?

If we land this without making the config / gui changes we need to be sure this gets documented so we do not forget todo it .

@nbolton iirc we were testing our linting on this pr ? that is all im waiting for to land

that is all im waiting for to land

I believe there are 3 things we need to do before landing:

• Testing of Clang lint workflow (ci: use job summary instead of pr comment #7569) -- though we don't necessarily need this to block, but it would be a nice test case
• [ ] Code smells (maintainability/clean code) need fixing (picked up by SonarCloud) -- I plan on fixing these after I'm finished fiddling with CI
• Raise an issue about adding a GUI setting for the scroll tweak values: Client mouse adjustment setting in GUI #7582

Edit: Actually, I think we can fix code smells on a different PR.

❌🛠️ clang-format: Lint errors, fix available.

Code style applied.

Edit: Download packages (available for limited time)

As the user, I can recommend rounding fractional numbers to the 1 because having a 0.5 coefficient means the mouse won't move during 1px movements. It wasn't enjoyable. Because of that, I implemented flooring (instead of rounding) with my limited knowledge of C++.

@neworld Do you think the current PR needs any more changes?

@spurin Are you happy for this to be merged in its current state?

@spurin Are you happy for this to be merged in its current state?

All good by me @nbolton

@spurin Are you happy for this to be merged in its current state?

All good by me @nbolton

@spurin I changed the env var to DESKFLOW_MOUSE_ADJUSTMENT as suggested by @sithlord48. Would you mind double-checking it works as expected with the renamed env var?

Approved once @spurin confirms the name change was successful.

It's looking good! Testing successful.

Approved once @spurin confirms the name change was successful.

@sithlord48 The change request is blocking the merge. Happy for me to dismiss your review, or would you prefer to re-approve?