refactor: Use member instead of passing param in daemon main loop

nbolton · nbolton · commit 30bbaa0effcf · 2025-02-27T15:36:46.000Z
diff --git a/src/lib/deskflow/DaemonApp.cpp b/src/lib/deskflow/DaemonApp.cpp
@@ -75,7 +75,7 @@ void DaemonApp::run()
 {
   if (m_foreground) {
     LOG_DEBUG("running daemon in foreground");
-    mainLoop(m_foreground);
+    mainLoop();
   } else {
     LOG_DEBUG("running daemon in background (daemonizing)");
     ARCH->daemonize(kAppName, daemonLoop);
@@ -209,13 +209,13 @@ DaemonApp::InitResult DaemonApp::init(int argc, char **argv) // NOSONAR - CLI ar
   return StartDaemon;
 }
 
-void DaemonApp::mainLoop(bool foreground)
+void DaemonApp::mainLoop()
 {
   try {
     DAEMON_RUNNING(true);
 
 #if SYSAPI_WIN32
-    m_watchdog = std::make_unique<MSWindowsWatchdog>(false, foreground);
+    m_watchdog = std::make_unique<MSWindowsWatchdog>(false, m_foreground);
     m_watchdog->setFileLogOutputter(m_fileLogOutputter);
 
     // install the platform event queue to handle service stop events.
diff --git a/src/lib/deskflow/DaemonApp.h b/src/lib/deskflow/DaemonApp.h
@@ -48,7 +48,7 @@ class DaemonApp : public QObject
   ~DaemonApp();
   InitResult init(int argc, char **argv);
   void run();
-  void mainLoop(bool foreground = false);
+  void mainLoop();
   void applyWatchdogCommand();
   void clearWatchdogCommand();
 
