SocketEndpoint can have multiple endpoints#1
Merged
propertone merged 4 commits intomainfrom Jul 30, 2025
Merged
Conversation
Refactor code to support this
mkomitee
requested changes
Jul 7, 2025
mkomitee
left a comment
There was a problem hiding this comment.
I think we should look into copilots suggestions here.
src/main.rs
Outdated
| peer.endpoints | ||
| .iter() | ||
| .fold(HashMap::new(), |mut acc, endpoint| { | ||
| let key = format!("{}[{}]", endpoint.name, endpoint.pid); |
There was a problem hiding this comment.
If key is used solely for the purpose of having a distinct hash key, then I think copilot's suggestion would be better.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SocketEndpoint structure to support multiple endpoints instead of a single endpoint, enabling better representation of socket connections where multiple file descriptors may be associated with the same socket inode.
- Changed
SocketEndpoint.endpointfield from singleFDEndpointtoVec<FDEndpoint>to support multiple endpoints - Updated the display logic to group and format multiple endpoints by process ID, showing them in a compact format like
foo[123][4,5] - Modified the socket mapping logic to collect all file descriptors associated with a socket inode and sort them consistently
mkomitee
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor code to support this