Closed
Conversation
derailed
requested changes
May 26, 2022
Owner
derailed
left a comment
There was a problem hiding this comment.
@bjorand I think that's a good idea so thank you for this! Tho it seems the implementation does not match the feature request?? Unless I am missing it, pressing 'n' on a selected pod will show all the nodes and not the specific node the pod is running on which I think is the whole idea here. Also might need counter measures here if the pod has no node allocated. Bonus: guessing the test suite will fail on this PR too ;(
Contributor
|
This is supported since |
Owner
|
@bripkens Thank you for verifying this Ben! Spaced that I'd made the necessary changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of copy/pasting the node name in the desc of a pod, I'd like to go to the node of a pod directly.
This PR implements a new keybinding
nin the pod list.Fix #1231