test(cli): add test to cover selenium-webdriver <4.17.0#1038
Merged
michael-siek merged 7 commits intodevelopfrom Apr 3, 2024
Merged
test(cli): add test to cover selenium-webdriver <4.17.0#1038michael-siek merged 7 commits intodevelopfrom
michael-siek merged 7 commits intodevelopfrom
Conversation
michael-siek
commented
Apr 2, 2024
michael-siek
commented
Apr 2, 2024
michael-siek
commented
Apr 2, 2024
Zidious
previously requested changes
Apr 2, 2024
Co-authored-by: Gabe <41127686+Zidious@users.noreply.github.com>
…re-npm into test/selenium-webdriver
Zidious
approved these changes
Apr 3, 2024
github-merge-queue bot
referenced
this pull request
in camunda/camunda
May 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@axe-core/playwright](https://togithub.com/dequelabs/axe-core-npm) | [`4.9.0` -> `4.9.1`](https://renovatebot.com/diffs/npm/@axe-core%2fplaywright/4.9.0/4.9.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dequelabs/axe-core-npm (@​axe-core/playwright)</summary> ### [`v4.9.1`](https://togithub.com/dequelabs/axe-core-npm/releases/tag/v4.9.1): Release 4.9.1 [Compare Source](https://togithub.com/dequelabs/axe-core-npm/compare/v4.9.0...v4.9.1) #### What's Changed - chore: bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1023](https://togithub.com/dequelabs/axe-core-npm/pull/1023) - test(cli): add test to cover selenium-webdriver <4.17.0 by [@​michael-siek](https://togithub.com/michael-siek) in [https://github.com/dequelabs/axe-core-npm/pull/1038](https://togithub.com/dequelabs/axe-core-npm/pull/1038) - chore: merge master into develop by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dequelabs/axe-core-npm/pull/1041](https://togithub.com/dequelabs/axe-core-npm/pull/1041) - chore: bump undici from 5.28.3 to 5.28.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1042](https://togithub.com/dequelabs/axe-core-npm/pull/1042) - chore: update test-fixtures to fix lazy load iframe by [@​straker](https://togithub.com/straker) in [https://github.com/dequelabs/axe-core-npm/pull/1053](https://togithub.com/dequelabs/axe-core-npm/pull/1053) - docs(react): Update React support information. Offer axe Developer Hub by [@​ballendq](https://togithub.com/ballendq) in [https://github.com/dequelabs/axe-core-npm/pull/1047](https://togithub.com/dequelabs/axe-core-npm/pull/1047) - fix: Update axe-core to v4.9.1 by [@​straker](https://togithub.com/straker) in [https://github.com/dequelabs/axe-core-npm/pull/1055](https://togithub.com/dequelabs/axe-core-npm/pull/1055) - chore: RC v4.9.1 by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dequelabs/axe-core-npm/pull/1057](https://togithub.com/dequelabs/axe-core-npm/pull/1057) - chore: Update axe-core to v4.9.1 by [@​attest-team-ci](https://togithub.com/attest-team-ci) in [https://github.com/dequelabs/axe-core-npm/pull/1056](https://togithub.com/dequelabs/axe-core-npm/pull/1056) - fix(playwright): skip unloaded iframes by [@​straker](https://togithub.com/straker) in [https://github.com/dequelabs/axe-core-npm/pull/1060](https://togithub.com/dequelabs/axe-core-npm/pull/1060) - chore: bump the npm-low-risk group across 1 directory with 28 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1061](https://togithub.com/dequelabs/axe-core-npm/pull/1061) - chore: bump ejs from 3.1.9 to 3.1.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1049](https://togithub.com/dequelabs/axe-core-npm/pull/1049) - ci: update sync to master to include team-reviewers by [@​michael-siek](https://togithub.com/michael-siek) in [https://github.com/dequelabs/axe-core-npm/pull/1062](https://togithub.com/dequelabs/axe-core-npm/pull/1062) - chore: RC v4.9.1 by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dequelabs/axe-core-npm/pull/1065](https://togithub.com/dequelabs/axe-core-npm/pull/1065) - Release v4.9.1 by [@​dequejenn](https://togithub.com/dequejenn) in [https://github.com/dequelabs/axe-core-npm/pull/1068](https://togithub.com/dequelabs/axe-core-npm/pull/1068) **Full Changelog**: dequelabs/axe-core-npm@v4.9.0...v4.9.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
github-merge-queue bot
referenced
this pull request
in camunda/camunda
May 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@axe-core/playwright](https://togithub.com/dequelabs/axe-core-npm) | [`4.9.0` -> `4.9.1`](https://renovatebot.com/diffs/npm/@axe-core%2fplaywright/4.9.0/4.9.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dequelabs/axe-core-npm (@​axe-core/playwright)</summary> ### [`v4.9.1`](https://togithub.com/dequelabs/axe-core-npm/releases/tag/v4.9.1): Release 4.9.1 [Compare Source](https://togithub.com/dequelabs/axe-core-npm/compare/v4.9.0...v4.9.1) #### What's Changed - chore: bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1023](https://togithub.com/dequelabs/axe-core-npm/pull/1023) - test(cli): add test to cover selenium-webdriver <4.17.0 by [@​michael-siek](https://togithub.com/michael-siek) in [https://github.com/dequelabs/axe-core-npm/pull/1038](https://togithub.com/dequelabs/axe-core-npm/pull/1038) - chore: merge master into develop by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dequelabs/axe-core-npm/pull/1041](https://togithub.com/dequelabs/axe-core-npm/pull/1041) - chore: bump undici from 5.28.3 to 5.28.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1042](https://togithub.com/dequelabs/axe-core-npm/pull/1042) - chore: update test-fixtures to fix lazy load iframe by [@​straker](https://togithub.com/straker) in [https://github.com/dequelabs/axe-core-npm/pull/1053](https://togithub.com/dequelabs/axe-core-npm/pull/1053) - docs(react): Update React support information. Offer axe Developer Hub by [@​ballendq](https://togithub.com/ballendq) in [https://github.com/dequelabs/axe-core-npm/pull/1047](https://togithub.com/dequelabs/axe-core-npm/pull/1047) - fix: Update axe-core to v4.9.1 by [@​straker](https://togithub.com/straker) in [https://github.com/dequelabs/axe-core-npm/pull/1055](https://togithub.com/dequelabs/axe-core-npm/pull/1055) - chore: RC v4.9.1 by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dequelabs/axe-core-npm/pull/1057](https://togithub.com/dequelabs/axe-core-npm/pull/1057) - chore: Update axe-core to v4.9.1 by [@​attest-team-ci](https://togithub.com/attest-team-ci) in [https://github.com/dequelabs/axe-core-npm/pull/1056](https://togithub.com/dequelabs/axe-core-npm/pull/1056) - fix(playwright): skip unloaded iframes by [@​straker](https://togithub.com/straker) in [https://github.com/dequelabs/axe-core-npm/pull/1060](https://togithub.com/dequelabs/axe-core-npm/pull/1060) - chore: bump the npm-low-risk group across 1 directory with 28 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1061](https://togithub.com/dequelabs/axe-core-npm/pull/1061) - chore: bump ejs from 3.1.9 to 3.1.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1049](https://togithub.com/dequelabs/axe-core-npm/pull/1049) - ci: update sync to master to include team-reviewers by [@​michael-siek](https://togithub.com/michael-siek) in [https://github.com/dequelabs/axe-core-npm/pull/1062](https://togithub.com/dequelabs/axe-core-npm/pull/1062) - chore: RC v4.9.1 by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dequelabs/axe-core-npm/pull/1065](https://togithub.com/dequelabs/axe-core-npm/pull/1065) - Release v4.9.1 by [@​dequejenn](https://togithub.com/dequejenn) in [https://github.com/dequelabs/axe-core-npm/pull/1068](https://togithub.com/dequelabs/axe-core-npm/pull/1068) **Full Changelog**: dequelabs/axe-core-npm@v4.9.0...v4.9.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
github-merge-queue bot
referenced
this pull request
in camunda/camunda
May 21, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@axe-core/playwright](https://togithub.com/dequelabs/axe-core-npm) | [`4.9.0` -> `4.9.1`](https://renovatebot.com/diffs/npm/@axe-core%2fplaywright/4.9.0/4.9.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dequelabs/axe-core-npm (@​axe-core/playwright)</summary> ### [`v4.9.1`](https://togithub.com/dequelabs/axe-core-npm/releases/tag/v4.9.1): Release 4.9.1 [Compare Source](https://togithub.com/dequelabs/axe-core-npm/compare/v4.9.0...v4.9.1) #### What's Changed - chore: bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1023](https://togithub.com/dequelabs/axe-core-npm/pull/1023) - test(cli): add test to cover selenium-webdriver <4.17.0 by [@​michael-siek](https://togithub.com/michael-siek) in [https://github.com/dequelabs/axe-core-npm/pull/1038](https://togithub.com/dequelabs/axe-core-npm/pull/1038) - chore: merge master into develop by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dequelabs/axe-core-npm/pull/1041](https://togithub.com/dequelabs/axe-core-npm/pull/1041) - chore: bump undici from 5.28.3 to 5.28.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1042](https://togithub.com/dequelabs/axe-core-npm/pull/1042) - chore: update test-fixtures to fix lazy load iframe by [@​straker](https://togithub.com/straker) in [https://github.com/dequelabs/axe-core-npm/pull/1053](https://togithub.com/dequelabs/axe-core-npm/pull/1053) - docs(react): Update React support information. Offer axe Developer Hub by [@​ballendq](https://togithub.com/ballendq) in [https://github.com/dequelabs/axe-core-npm/pull/1047](https://togithub.com/dequelabs/axe-core-npm/pull/1047) - fix: Update axe-core to v4.9.1 by [@​straker](https://togithub.com/straker) in [https://github.com/dequelabs/axe-core-npm/pull/1055](https://togithub.com/dequelabs/axe-core-npm/pull/1055) - chore: RC v4.9.1 by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dequelabs/axe-core-npm/pull/1057](https://togithub.com/dequelabs/axe-core-npm/pull/1057) - chore: Update axe-core to v4.9.1 by [@​attest-team-ci](https://togithub.com/attest-team-ci) in [https://github.com/dequelabs/axe-core-npm/pull/1056](https://togithub.com/dequelabs/axe-core-npm/pull/1056) - fix(playwright): skip unloaded iframes by [@​straker](https://togithub.com/straker) in [https://github.com/dequelabs/axe-core-npm/pull/1060](https://togithub.com/dequelabs/axe-core-npm/pull/1060) - chore: bump the npm-low-risk group across 1 directory with 28 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1061](https://togithub.com/dequelabs/axe-core-npm/pull/1061) - chore: bump ejs from 3.1.9 to 3.1.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dequelabs/axe-core-npm/pull/1049](https://togithub.com/dequelabs/axe-core-npm/pull/1049) - ci: update sync to master to include team-reviewers by [@​michael-siek](https://togithub.com/michael-siek) in [https://github.com/dequelabs/axe-core-npm/pull/1062](https://togithub.com/dequelabs/axe-core-npm/pull/1062) - chore: RC v4.9.1 by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dequelabs/axe-core-npm/pull/1065](https://togithub.com/dequelabs/axe-core-npm/pull/1065) - Release v4.9.1 by [@​dequejenn](https://togithub.com/dequejenn) in [https://github.com/dequelabs/axe-core-npm/pull/1068](https://togithub.com/dequelabs/axe-core-npm/pull/1068) **Full Changelog**: dequelabs/axe-core-npm@v4.9.0...v4.9.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
This was referenced Jul 16, 2024
This was referenced Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test to cover the event that users are using selenium-webdriver <4.17.0 and chrome options use the "old" way of supporting headless runs. Also did some cleanup and removed code that wasn't required in cli
no qa required