Skip to content

fix(webdriverio): work with @wdio/globals#882

Merged
straker merged 5 commits intodevelopfrom
fix-wdio-globals
Oct 24, 2023
Merged

fix(webdriverio): work with @wdio/globals#882
straker merged 5 commits intodevelopfrom
fix-wdio-globals

Conversation

@straker
Copy link
Copy Markdown
Contributor

@straker straker commented Oct 20, 2023

When using @wdio/globals, browser is a function and not an object (thanks wdio).

Closes: #798

@straker straker requested a review from a team as a code owner October 20, 2023 17:33
Copy link
Copy Markdown
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about test-listen otherwise LGTM

Comment thread test/wdio/wdio-globals.spec.ts
Comment thread test/wdio/wdio-globals.spec.ts
Comment thread packages/webdriverio/src/utils.ts Outdated
Copy link
Copy Markdown
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error occurs when WebdriverIO version is higher than 5

2 participants