Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Node.js version specified in .nvmrc from 22 to 24 for development and CI environments. The change aims to enable npm@11 by default to fix deployment issues referenced in issue #4912.
Key Changes:
- Updated
.nvmrcto specify Node.js version 24
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
straker
previously requested changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Please also update the developer guide with the node change.
Updated the dev guide and the eslint config for the new github scripts to have the right context.
straker
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates the configured node version to use 24 for development and CI purposes. Which installs npm@11 by default to fix the deployment process. The developer guide has the new version as well as the eslint config for the newer GitHub scripts to have the right context.
Closes: #4912